[TYPO3-core] RFC #9994: Bug: ereg_replace is deprecated in PHP 5.3 alpha3

Karsten Dambekalns karsten at typo3.org
Thu Jan 22 14:24:12 CET 2009


Hi.

On 22.01.2009, at 12:55, Niels Pardon wrote:
> Karsten Dambekalns schrieb:
>> After applying that to SVN as of yesterday, I still get a ton of
>> warnings, and searching the sources finds 150 matches for ereg_
>>
>> I'll send another patch later on, if noone has worked on that  
>> already or
>> proves my count wrong. :)
>
> I did not want to make this patch too huge. So I only took the
> ereg_replace() calls into account. The other ereg() function calls  
> would
> have been the next on my list. Feel free to go ahead.

Well, ereg_ does not include ereg. ;) Replacing ereg() is another  
task, but IMHO it makes sense to tackle those 159 places in the same  
patch.

There are some places where a simple str_replace could be used as  
well, like when replacing "=" against nothing.

I would say "[:alnum:]" should be replaced by "A-Za-z0-9" as that is  
what it is. There are quite some places where "[:alnum:]_" is used  
currently, so we should replace things with the exact equivalent.

See also the (freshly created) issue #10226 [1] for a related problem.

Regards,
Karsten

[1] http://bugs.typo3.org/view.php?id=10226

-- 
Karsten Dambekalns
Gimme Five!
http://typo3.org/gimmefive


-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 312 bytes
Desc: This is a digitally signed message part
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090122/566df117/attachment.pgp 


More information about the TYPO3-team-core mailing list