[TYPO3-core] RFC: Bugfix #10064: sysext fe_edit: config.admPanel without effect

[Ralf Hettinger]

Am 13.01.2009 22:52 schrieb Jeff Segars:
> Ralf Hettinger wrote:
>> Am 06.01.2009 17:12 schrieb Jeff Segars:
>>> Ralf Hettinger wrote:
>>>> This is an SVN patch request.
>>>>
>>>> Type: Bugfix
>>>>
>>>> Bugtracker references:
>>>> http://bugs.typo3.org/view.php?id=10064
>>>>
>>>> Branches:
>>>> trunk only
>>>>
>>>>
>>>> Problem:
>>>> After moving frontend editing to a separate sysext (see
>>>> http://bugs.typo3.org/view.php?id=9615), the template TS property
>>>> config.admPanel (respectively config.[pageObj].admPanel) has no effect
>>>> any longer, which is a regression in functionality in current 4.3
>>>> alpha1
>>>> (e.g. you can't switch the Admin Panel off for certain branches only).
>>>>
>>>> Quoting [1]: "Notice the fact that the visibility of the admin panel is
>>>> ultimately depending on being configured in your TypoScript template
>>>> for
>>>> the website! This is easily done by inserting this string in the
>>>> TypoScript Template:
>>>>
>>>> config.admPanel = 1
>>>>
>>>> or if you use frames, this is probably better:
>>>>
>>>> page.config.admPanel = 1"
>>>>
>>>>
>>>> Solution:
>>>> Respect $GLOBALS['TSFE']->config['config']['admPanel'] when drawing a
>>>> TYPO3 page as it has been done before fe_edit.
>>>>
>>>>
>>>> [1]
>>>> http://typo3.org/documentation/document-library/references/doc_core_tsconfig/4.2.0/view/1/2/
>>>>
>>>>
>>> Hey Ralf,
>>> Thanks for catching that one!  What do you think about doing the check
>>> inside t3lib_frontendedit->displayAdmin() instead? One of the things we
>>> tried to do with the original fe_edit patch was simplify index_ts.php by
>>> moving frontend editing logic out of it.
>>>
>>> Thanks,
>>> Jeff
>>
>> Hi Jeff,
>>
>> I thought about that as well and was pretty undecided indeed.
>>
>> By reading the documentation "[...] is ultimately depending on [...]" I
>> felt like it was adequate to have this condition "outside" of fe_edit,
>> that's why I put it where I put it ;)
>>
>> And it might be more performant to disable it outside of fe_edit as
>> well... but won't be of much difference probably.
>>
>>
>> Cheers
>> Ralf
> 
> Hey Ralf,
> Just circling back to this again.  I'm fine with either patch also since
>  its not a major difference.
> 
> Still need another +1 and then I'll handle the commit.
> 
> Thanks,
> Jeff

Hi Jeff,

thanks for your feedback.
Looking forward to one more +1 as well :)

Ralf