[TYPO3-core] RFC: Bugfix #5630: Install tool removes dots from admin usernames and replace ereg_replace with preg_replace

Oliver Hader oliver at typo3.org
Sun Jan 11 16:06:03 CET 2009


FYI: The attached patch was committed to SVN:
* TYPO3_4-2 (rev. 4687)
* Trunk (rev. 4688)

The behaviour is the same as before but allowing now the dot "."...

olly


Stefano Kowalke schrieb:
> Hi!
> 
> This is a patch request.
> 
> BT reference: http://bugs.typo3.org/view.php?id=5630
> 
> Branch: 4.2, trunk
> 
> Problem: 
> When attempting to create admin user with the following username:
> vlatko.surlan the dot gets removed from the username and finally user
> vlatkosurlan gets created. If this is a feature then it is a bad one. It
> should either reject the username as invalid or create it as specified but
> not modify user input under the hood and create something modified.
> 
> Solution:
> * add the dot "." to the regex:
> Before:
> [^[:alnum:]_-]
> 
> After:
> [^[:alnum:]._-]
> 
> 
> * replace ereg_replace with preg_replace
> Before:
> ereg_replace('[^[:alnum:]._-] ...
> 
> After
> preg_replace('[^A-Za-z0-9._-] ...
> 
> 
> Note:
> This issue was reported by Vlatko Šurlan
> 
> Cheers
> Stefano
-- 
Oliver Hader
TYPO3 4.3 Release Manager
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005630_v3.patch
Type: text/x-diff
Size: 943 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090111/961be02d/attachment.patch 


More information about the TYPO3-team-core mailing list