[TYPO3-core] FYI24: #10067: common.js uses undefined variable

Oliver Hader oliver at typo3.org
Thu Jan 8 21:00:23 CET 2009


Hi Dmitry,

Dmitry Dulepov schrieb:
> Hi!
> 
> This is SVN patch request.
> 
> Type: bug
> 
> Branches: trunk
> 
> BT reference: http://bugs.typo3.org/view.php?id=10067
> 
> Problem: common.js contains the following blocks of code:
> 	} else if (!json) {
>     		T3AJAX.showError(xhr, json);
> 	} else {
> This code is called when JSON cannot be parsed and therefore the value is undefined. So there is no point to pass it anywhere. The function T3AJAX.showError() does not use this value anyway.
> 
> Solution: the attached patch removes this parameter from the function call and also shows ExtJS alert instead of standard browser if ExtJS is available.
> 
> Notes: I believe that this code is responsible for showing "undefined" messages with FireBug active.

+1 on reading - please go ahead with the commit! :)

olly
-- 
Oliver Hader
TYPO3 4.3 Release Manager


More information about the TYPO3-team-core mailing list