[TYPO3-core] RFC #9194: Bug: wrong handling of 'is_in' list in TCA element type 'input'

[Vladimir Podkovanov]

Hi Benjamin,
I've left strstr untouched as I've corrected only logical condition. But 
you are right strpos should be better, so I've attached new patch.

On myltibyte safe solution – I think the whole class 
class.t3lib_tcemain.php should be fixed regarding myltibyte handling as 
it has few other instances of strstr(), substr(), strtoupper(), 
strtolower(), strlen(), str_replace(), ereg_replace() and handling only 
one instance doesn't change picture in general but makes false feeling 
it is fixed. So I've reported mb issue here 
http://bugs.typo3.org/view.php?id=10070 to keep it in mind and we can 
commit present patch without mb.


Benjamin Mack wrote:
> Hey Vladimir,
> 
> I saw your patch is still open.
> 
> Why not use "strpos" for the issue? It's supposed to be faster. 
> Otherwise a +1 by reading.
> 
> Also, could you prepare a multibyte safe patch fixing the issue Masi 
> addressed?
> 
> All the best,
> benni.
> 
> On 15.10.2008 4:42 Uhr, Vladimir Podkovanov wrote:
>> Hi!
>>
>> This is an SVN patch request.
>>
>> Type: Bugfix
>>
>> Bugtracker references: http://bugs.typo3.org/view.php?id=9194
>>
>> Branches: TYPO3_4-1, TYPO3_4-2, trunk
>>
>> Problem:
>> when 'is_in' string in TCA element type 'input' ends with symbol '0'
>> (say '1234567890') then '0' is not taken into account so 0's stripped
>> off from field value
>>
>> Solution:
>> changed logical condition to avoid evaluation of string '0' as false
>>
>