[TYPO3-core] FYI24: #10067: common.js uses undefined variable

Dmitry Dulepov dmitry at typo3.org
Tue Jan 6 19:30:34 CET 2009


Hi!

This is SVN patch request.

Type: bug

Branches: trunk

BT reference: http://bugs.typo3.org/view.php?id=10067

Problem: common.js contains the following blocks of code:
	} else if (!json) {
    		T3AJAX.showError(xhr, json);
	} else {
This code is called when JSON cannot be parsed and therefore the value is undefined. So there is no point to pass it anywhere. The function T3AJAX.showError() does not use this value anyway.

Solution: the attached patch removes this parameter from the function call and also shows ExtJS alert instead of standard browser if ExtJS is available.

Notes: I believe that this code is responsible for showing "undefined" messages with FireBug active.

-- 
Dmitry Dulepov
TYPO3 core team

Mr. Harris: People say that you were the last person to speak with Jordon...
            Is that true? 
Cameron: I don't know. Are you asking me if people say I was the last person
            to talk to Jordon? Or are you asking me if I was the last person
            to talk to her? 
Mr. Harris: I guess I'm asking if you were. 
Cameron: I don't know. 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 10067.diff
Type: text/x-diff
Size: 1007 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090106/fefe089f/attachment.diff 


More information about the TYPO3-team-core mailing list