[TYPO3-core] RFC: Bug #10099: Use TYPO3_DB->exec_SELECTcountRows() to determine the number of rows

[Michael Stucki]

Hi Olly,

I reviewed the patch without testing yet, but it seems almost perfect to
me. Great work!

One thing though: In tslib/class.tslib_fetce.php, you have added an
intval() statement to the end of the $doublePostField check. I looked at
the code and the value should always come from hexdec, which means
"number". So the addition will most likely not hurt, but I can't say for
sure. What I would like in any case is that this change (and more if I
overlooked any others) is moved into a separate commit.

+1 after that part is removed.

Thinking about how to test the patch: It's pretty difficult to test the
behaviour of 23 different files. In this case here I think it makes
sense to carefully review the code and if it is ok, commit it.

- michael

Oliver Hader schrieb:
> Hi,
> 
> attached is a new modified patch with the following fixes:
> * fixed bug in array concatenation in t3lib_superadmin
> * fixed wrong if condition in t3lib_div::makeRedirectUrl()
> * fixed wrong if condition in
> tx_indexedsearch_crawler::cleanUpOldRunningConfigurations()
> 
> olly
> 
> 
> Oliver Hader schrieb:
>> This is a SVN patch request.
>>
>> Problem:
>> In the TYPO Core counting rows is/was implemented as the following:
>> * get result set for a "COUNT(*)" query, fetch row, free result set (not
>> in all cases)
>> * get result set for a regular table SELECT, get sql_num_rows, free
>> result set (not in all cases again)
>>
>> Solution:
>> To prevent hanging record sets here and simplify the code,
>> TYPO3_DB->exec_SELECTcountRows() is going to be used.
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=10099
>>
>> Branch: Trunk
>>
>>
>> olly


-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/