[TYPO3-core] RFC #5466: Feature: Page selector for the list module

Francois Suter fsuter at cobweb.ch
Fri Feb 27 14:44:47 CET 2009


Hi,

> Attached v6: This merges the icon renaming from my v4 into your version,
>   the refresh button is removed from icon pack.

I had much the same remarks as Ingo, especially concerning the labels. 
Other remarks:

1) the label "pageIndicator" should include position markers in the 
string in case the sentence is written differently in another language:

<label index="pageIndicator">Page %1$s of %2$d</label>

2) the icons have to be added to typo3/gfx too, otherwise they are 
missing when not using t3skin. Actually the icons don't quite match the 
look of the old skin, but it's not so bad, so I would add them as is.

3) without t3skin, the icons are shifted down and look out of place. Can 
you check that, please?

4) the patch also adds a comment to the PHPdoc of recordList::listURL(). 
This is not related to this RFC. I would rather have it removed.

Cheers

-- 

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch


More information about the TYPO3-team-core mailing list