[TYPO3-core] RFC: #10515: extend Filelist with icon block according to list view

Niels Pardon mail at niels-pardon.de
Sat Feb 21 13:51:32 CET 2009


Hi Steffen!

The screenshot looks really good!

You should be more consistent in your patch and following the CGL, e.g.:

- Putting commas after the last array element if it is not an one-liner.
- Putting spaces around dots for concatenation.
- Putting spaces after commas in function parameter lists.
- Putting spaces around the operators within if conditions.
- Tabs for indendation only at the beginning of a line.

What about adding visibility keywords to new class attributes and
modified functions?

Greets,

Niels


More information about the TYPO3-team-core mailing list