[TYPO3-core] RFC #10511: simplify and speed up t3lib_div::trimExplode()

Ingo Renner ingo at typo3.org
Sat Feb 21 11:25:23 CET 2009


Peter Foerger wrote:

Hi Peter,

> Two remarks:
> - will that work in terms of the expected result?:
> t3lib_div::trimExplode(',', $testString, true, 3);
> @see http://bugs.typo3.org/view.php?id=9779

I'll check it and add a testcase, thanks.

> - benchmark_trimExplode.php::trimExplode2()
> the conditional should be 'if ($onlyNonEmptyValues){}' as
> $removeEmptyValues is undefined.

upps, I think that's because I just copoied the function body over to 
the benchmark after I added the comments and changed the variable name.


Thanks for the hints
Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2


More information about the TYPO3-team-core mailing list