[TYPO3-core] RFC: Bugfix #10212: Missing files in sysext install

Steffen Kamper info at sk-typo3.de
Sat Feb 14 14:42:23 CET 2009


Hi,

what's the problem? When in doubt use JSlint.

Following problems occured:
* 2 extra comma (this stopped IE)
* wrong include order (prototype must be first one)
* inclusion should be done in head section of document.

I fixed all this issues, see attached patch

vg Steffen

Marcus Krause schrieb:
> Steffen Müller schrieb am 02/14/2009 01:24 PM Uhr:
>> Hi.
>>
>> On 14.02.2009 13:09 Marcus Krause wrote:
>>> Steffen Müller schrieb am 02/14/2009 12:48 PM Uhr:
>>>> -1
>>>> after testing with trunk rev.5017
>>>>
>>>> The patch does not work on:
>>>> IE6, IE7 on WinXP
>>>>
>>>> I get a Javascript error:
>>>> 'EncryptionKey' is undefined (=config,210)
>>> Could we please focus on this issue?
>>>
>>> As you are already aware of (you commented it), there's issue #10410
>>> regarding IE problems!
>>>
>> Your patch 10212_v2.diff did not fix #10212 for IE6 and IE7. I voted -1
>> to stop committing patches which do not pass browser compatibility
>> check. There have been some discussions about this before and I acted
>> according to.
> 
> Okay, no problem. I hereby stop sending patches. I'm unable to
> reproduce/fix IE issues as I simply don't use them.
> 
> Hope someone steps in and takes care.
> 
> 
> Have fun,
> 
> Marcus.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 10212_v3.diff
Type: text/x-diff
Size: 8679 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090214/bf8af4a0/attachment-0001.diff 


More information about the TYPO3-team-core mailing list