[TYPO3-core] RFC #10380: Update t3editor base (CodeMirror) to current release 0.60

Tobias Liebig liebig at networkteam.com
Mon Feb 9 12:41:08 CET 2009


Dmitry Dulepov schrieb:
> Hi!
> 
> Tobias Liebig wrote:
>> The attached patch ...
>> * updates the codemirror javascript files
>> * raises the t3editor version number
> 
> This is one thing.
> 
>> * cleans up some code
> 
> This is another thing.
> 
>> * make use of the new api (e.g. when counting the lines)
> 
> The is the third thing.
> 
>> * remove the obsolete code for checking matching brackets
> 
> This is the fourth thing.
> 
> There are four different things. They should be committed separately in order to clearly see where each part ends and another one starts. Suppose there is a critical problem in this large patch. If there is, we will revert the whole patch. If there were 4 different patches, we could revert only one.
> 
> I do not like huge patches. I prefer to do as Michael requests: one issue per patch/commit. This is a very careful, good and weighted position. I want all patches to follow that request.
> 
> This patch should be split. The RFC number can be one but there should different patches and different commits.
> 

Yes, i see the problem.
I will try to split the patch like you suggested. i hope i can do it 
this evening, maybe tomorrow.
Thanks.

regards
    tobias


More information about the TYPO3-team-core mailing list