[TYPO3-core] RFC: #10377: Some errors in typo3/js-scripts causes some trouble

Martin Kutschker masi-no at spam-typo3.org
Sat Feb 7 22:25:12 CET 2009


Steffen Kamper schrieb:
> This is SVN patch request.
> 
> Type: Bugfix
> 
> Branches: trunk, 4_2
> 
> BT reference: http://bugs.typo3.org/view.php?id=10377
> 
> I investigated the scripts in typo3/js with JSlint and found some
> problems which i solved.
> 
> As positive side effect the backendsearch-box now has a visible cursor.
> 
> I changed these issues:
> * added missing semicolons

They are optional in JS, but I think it's good practice always to add them.

> * used === and !== with compare of integer and string

Ok.

> * added radix for parseInt

I don't see this in the patch. What's the purpose of this anway?

> * changed a = new Array(); to a = [];
> * changed a = new Object(); to a = {};

Why? Is this required by our JS CGL?

> * some vars where prefixed with var where they was defined before

I hope  you made none global by accident.

Masi


More information about the TYPO3-team-core mailing list