[TYPO3-core] RFC #13026 : Install tool doesn´t reconize comments in localconf.php

[Stefano Kowalke]

This is SVN patch request.

Type: Bugfix

Branches: 4.3, trunk

BT reference: http://bugs.typo3.org/view.php?id=13026

Problem:
If you have a localconf.php like this below and you switch to a new
major version (4.2 -> 4.3), Update Wizard suggest you to perform an
update. After this you got a message like this:
"changeCompatibilityVersion
Update successful!


The compatibility version has been set to 4.4." but if you run the
Update Wizard again, you get same notice to do an upgrade.

This happens because the wizard update the first occurence of the
variable (reads from bottom to top), doesn´t matter if it inside a comment.
On the other hand the Wizard take care for comments if he compare
installed version against new version to detect if an update needed.
So this behavior is inconstistent.

 	
---SNIP---
$TYPO3_CONF_VARS['SYS']['compat_version'] = '4.2'; // Modified or
inserted by TYPO3 Install Tool.
$TYPO3_CONF_VARS['SYS']['UTF8filesystem'] = '1';
$TYPO3_CONF_VARS['SYS']['textfile_ext'] =
'txt,html,htm,css,inc,php,php3,tmpl,js,sql,ts,t3s,t3c';
$TYPO3_CONF_VARS['BE']['sessionTimeout'] = '36000'; // Modified or
inserted by TYPO3 Install Tool.
$
/*
$TYPO3_CONF_VARS['SYS']['compat_version'] = '4.2'; // Modified or
inserted by TYPO3 Install Tool.
*/
---SNIP---


Solution: With this patch update wizard ignore lines between /* */ and
behind #.

LG Stefano
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 13026 .diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20091213/b6119433/attachment.txt>