[TYPO3-core] RFC: #10327: [felogin] redirecting to referer does not work
benni at typo3.org
Mon Dec 7 07:49:46 CET 2009
I reviewed your v4 version of the patch.
First of all, your patch does not apply cleanly anymore for the 4_3
branch. After taking care of that, redirecting in 4.3 finally works
again, so this is a must have for 4.3! So: +1 after testing.
I also think that you might want to commit to 4.2, 4.3 and trunk.
However, I recommend only to commit to 4.3 and trunk for now.
Some remarks after reading your patch:
+ $return = implode(',', $redirect_url);
+ return t3lib_div::trimExplode(',', $return, TRUE);
I would never use a keyword as variable name, it just confuses people.
Just put everything in one line, that should work.
+ return t3lib_div::trimExplode(',', implode(',', $redirect_url);, TRUE);
Although this change is fine for trunk, please don't do that for a
stable version, I recall one incident not too long ago where a change
like this made some exts not to work anymore.
- var $userIsLoggedIn; // Is user logged in?
- var $template;
- var $uploadDir;
- var $redirectUrl;
+ protected $userIsLoggedIn; // Is user logged in?
+ protected $template;
+ protected $uploadDir;
+ protected $redirectUrl;
protected $noRedirect = false;
+ protected $logintype;
For trunk: Could you also be more descriptive on the variables (what
The rest of the patch looks good so far.
All the best,
More information about the TYPO3-team-core