[TYPO3-core] RFC: #12872: Use "strong" instead of "b"

Oliver Klee typo3-german-02 at oliverklee.de
Tue Dec 1 15:00:04 CET 2009


Hi,

+1 by reading with the following changes (and the issue fixed which the
other Steffen has mentioned):

> Index: typo3/backend.php
> ===================================================================
> @@ -415,7 +415,7 @@
>  
>  			// Convert labels/settings back to UTF-8 since json_encode() only works with UTF-8:
>  		if ($GLOBALS['LANG']->charSet !== 'utf-8') {
> -			$t3Configuration['username'] = $GLOBALS['LANG']->csConvObj->conv($t3Configuration['username'], $GLOBALS['LANG']->charSet, 'utf-8');
> +			$GLOBALS['LANG']->csConvObj->convArray($t3Configuration, $GLOBALS['LANG']->charSet, 'utf-8');

This doesn't seem to belong in this patch.

> Index: typo3/class.file_list.inc
> ===================================================================
> @@ -180,7 +180,7 @@
>  				if ($this->clickMenus) $otherMarkers['PAGE_ICON'] = $GLOBALS['SOBE']->doc->wrapClickMenuOnIcon($otherMarkers['PAGE_ICON'],$path);
>  
>  				$buttons['level_up'] .= $this->linkWrapDir('<img'.t3lib_iconWorks::skinImg($this->backPath,'gfx/i/folder_up.gif','width="18" height="16"').' title="'.$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_core.xml:labels.upOneLevel',1).'" alt="'.$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_core.xml:labels.upOneLevel',1).'" />',$theFile['path']);
> -				$otherMarkers['TITLE'] .= t3lib_div::fixed_lgd_cs($title,-($this->fixedL+20));	// No HTML specialchars here - HTML like <b> </b> is allowed
> +				$otherMarkers['TITLE'] .= t3lib_div::fixed_lgd_cs($title,-($this->fixedL+20));	// No HTML specialchars here - HTML like <strong> </strongb> is allowed

</strongb> -> </strong>

> Index: typo3/mod/user/ws/wsol_preview.php
> ===================================================================
> @@ -89,17 +89,17 @@
>  						<title>Header</title>
>  					</head>
>  					<body bgcolor="'.$color.'">
> -						<font face="verdana,arial" size="2" color="white"><b>'.$headerText.'</b></font>
> +						<strong style="font-family:Verdana, Arial;font-size:80%;color:white;>'.$headerText.'</strong>

white;> -> white;">

> Index: typo3/sysext/install/updates/class.tx_coreupdates_compatversion.php
> ===================================================================
> @@ -66,7 +66,7 @@
>  				The compatibility version has been set to the current TYPO3 version. This is a stamp and has no impact for your installation.';
>  			}
>  		} else {
> -			$description = 'Your current TYPO3 installation is configured to <b>behave like version '.$TYPO3_CONF_VARS['SYS']['compat_version'].'</b> of TYPO3. If you just upgraded from this version, you most likely want to <b>use new features</b> as well.</p><p>In the next step, you will see the things that need to be adjusted to make your installation compatible with the new features.';
> +			$description = 'Your current TYPO3 installation is configured to <strong>behave like version '.$TYPO3_CONF_VARS['SYS']['compat_version'].'</strong> of TYPO3. If you just upgraded from this version, you most likely want to <b>use new features</b> as well.</p><p>In the next step, you will see the things that need to be adjusted to make your installation compatible with the new features.';

You've missed a pair of <b></b> here.


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member


More information about the TYPO3-team-core mailing list