[TYPO3-core] FYI24: Re: RFC: #2278 -
Christian Kuhn
lolli at schwarzbu.ch
Sat Aug 29 16:36:01 CEST 2009
Hey Michael,
Michael Stucki wrote:
> After a long break (2 years, to be precise ;-)), here is a reminder.
As this FYI24 still didn't make it I take the opportunity for a small
review ;)
- Please get rid of the double foreach, one should be sufficient.
- If you call a specific method in your hook object we should introduce
an interface, a small unit test would also be really great (we've done
similar things for #9292 and #11431 recently)
- Please get rid of global declaration
Regards
Christian
More information about the TYPO3-team-core
mailing list