[TYPO3-core] RFC #11773: Integrate an option to deactivate shortcuts completely
Christopher Stelmaszyk
christopher at yahoo.de
Thu Aug 27 11:13:59 CEST 2009
Hi Ingo,
"Ingo Renner" schrieb:
> Christopher Stelmaszyk wrote:
>
> I'm -1 to the patch unless you change the negating name into a positive
> on. - we really have to move away from that stupidity.
>
> I'd suggest to name the option
>
> options.enableShortcuts
>
> and have it default to 1.
Done, see version 2.
> Besides that I wonder of what use it is to disable shortcuts...
Just think of small websites or of users who only see a small part of a
tree. They don't really need shortcuts.
Besides that I think that a BE which is tidied up generally makes life
easier; especially for beginners and for users who use TYPO3 seldom.
That is what this option should do. :-)
Christopher
Index: typo3/classes/class.shortcutmenu.php
===================================================================
--- typo3/classes/class.shortcutmenu.php (revision 5830)
+++ typo3/classes/class.shortcutmenu.php (working copy)
@@ -99,8 +99,10 @@
* @return boolean true if user has access, false if not
*/
public function checkAccess() {
- // Shortcut module is enabled for everybody
- return true;
+ if ($GLOBALS['BE_USER']->getTSConfigVal('options.enableShortcuts')) {
+ return true;
+ }
+ return false;
}
/**
Index: t3lib/class.t3lib_userauthgroup.php
===================================================================
--- t3lib/class.t3lib_userauthgroup.php (revision 5830)
+++ t3lib/class.t3lib_userauthgroup.php (working copy)
@@ -656,7 +656,9 @@
* @return boolean
*/
function mayMakeShortcut() {
- return $this->getTSConfigVal('options.shortcutFrame') &&
!$this->getTSConfigVal('options.mayNotCreateEditShortcuts');
+ return $this->getTSConfigVal('options.enableShortcuts') &&
+ $this->getTSConfigVal('options.shortcutFrame') &&
+ !$this->getTSConfigVal('options.mayNotCreateEditShortcuts');
}
/**
Index: t3lib/config_default.php
===================================================================
--- t3lib/config_default.php (revision 5830)
+++ t3lib/config_default.php (working copy)
@@ -202,7 +202,8 @@
'forceCharset' => '', // String. Normally the charset of the backend
users language selection is used. If you set this value to a charset found
in t3lib/csconvtbl/ (or "utf-8") the backend (and database) will ALWAYS use
this charset. Always use a lowercase value.
'installToolPassword' => '', // String. This is the md5-hashed password
for the Install Tool. Set this to '' and access will be totally denied.
PLEASE consider to externally password protect the typo3/install/ folder,
eg. with a .htaccess file.
'trackBeUser' => 0, // Boolean. If set, every invokation of a
backend script is logged in sys_trackbeuser. This is used to get a view of
the backend users behaviour. Mostly for debugging, support and user
interaction analysis. Requires 'beuser_tracking' extension.
- 'defaultUserTSconfig' => 'options.shortcutFrame=1', // String. Enter
lines of default backend user/group TSconfig.
+ 'defaultUserTSconfig' => 'options.shortcutFrame=1
+ options.enableShortcuts=1', // String. Enter lines of default backend
user/group TSconfig.
'defaultPageTSconfig' => '', // Enter lines of default Page TSconfig.
'defaultPermissions' => array ( // Default permissions set for new
pages in t3lib/tce_main.php. Keys are 'show,edit,delete,new,editcontent'.
Enter as comma-list
// 'user' => '', // default in tce_main is
'show,edit,delete,new,editcontent'. If this is set (uncomment), this value
is used instead.
begin 666 11773_enableShortcuts_v2.patch
M26YD97 at Z('1Y<&\S+V-L87-S97,O8VQA<W,N<VAO<G1C=71M96YU+G!H< H]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]"BTM+2!T>7!O,R]C;&%S<V5S+V-L87-S
M+G-H;W)T8W5T;65N=2YP:' )*')E=FES:6]N(#4X,S I"BLK*R!T>7!O,R]C
M;&%S<V5S+V-L87-S+G-H;W)T8W5T;65N=2YP:' )*'=O<FMI;F<@8V]P>2D*
M0$ @+3DY+#@@*SDY+#$P($! "B )("H at 0')E='5R;B @8F]O;&5A;B @=')U
M92!I9B!U<V5R(&AA<R!A8V-E<W,L(&9A;'-E(&EF(&YO= H@"2 J+PH@"7!U
M8FQI8R!F=6YC=&EO;B!C:&5C:T%C8V5S<R at I('L*+0D)"2\O(%-H;W)T8W5T
M(&UO9'5L92!I<R!E;F%B;&5D(&9O<B!E=F5R>6)O9'D*+0D)<F5T=7)N('1R
M=64["BL)"6EF("@D1TQ/0D%,4ULG0D5?55-%4B==+3YG97144T-O;F9I9U9A
M;"@G;W!T:6]N<RYE;F%B;&53:&]R=&-U=',G*2D@>PHK"0D)<F5T=7)N('1R
M=64["BL)"7T**PD)<F5T=7)N(&9A;'-E.PH@"7T*"B )+RHJ"DEN9&5X.B!T
M,VQI8B]C;&%S<RYT,VQI8E]U<V5R875T:&=R;W5P+G!H< H]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]"BTM+2!T,VQI8B]C;&%S<RYT,VQI8E]U<V5R875T:&=R
M;W5P+G!H< DH<F5V:7-I;VX at -3@S,"D**RLK('0S;&EB+V-L87-S+G0S;&EB
M7W5S97)A=71H9W)O=7 N<&AP"2AW;W)K:6YG(&-O<'DI"D! ("TV-38L-R K
M-C4V+#D at 0$ *( D@*B! <F5T=7)N"6)O;VQE86X*( D@*B\*( EF=6YC=&EO
M;B!M87E-86ME4VAO<G1C=70H*0E["BT)"7)E='5R;B D=&AI<RT^9V5T5%-#
M;VYF:6=686PH)V]P=&EO;G,N<VAO<G1C=71&<F%M92<I("8F("$D=&AI<RT^
M9V5T5%-#;VYF:6=686PH)V]P=&EO;G,N;6%Y3F]T0W)E871E161I=%-H;W)T
M8W5T<R<I.PHK"0ER971U<FX@)'1H:7,M/F=E=%130V]N9FEG5F%L*"=O<'1I
M;VYS+F5N86)L95-H;W)T8W5T<R<I("8F"BL)"0DD=&AI<RT^9V5T5%-#;VYF
M:6=686PH)V]P=&EO;G,N<VAO<G1C=71&<F%M92<I("8F"BL)"0DA)'1H:7,M
M/F=E=%130V]N9FEG5F%L*"=O<'1I;VYS+FUA>4YO=$-R96%T945D:713:&]R
M=&-U=',G*3L*( E]"@H@"2\J*@I);F1E>#H@=#-L:6(O8V]N9FEG7V1E9F%U
M;'0N<&AP"CT]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T*+2TM('0S;&EB+V-O;F9I
M9U]D969A=6QT+G!H< DH<F5V:7-I;VX at -3@S,"D**RLK('0S;&EB+V-O;F9I
M9U]D969A=6QT+G!H< DH=V]R:VEN9R!C;W!Y*0I 0" M,C R+#<@*S(P,BPX
M($! "B )"2=F;W)C94-H87)S970G(#T^("<G+ D)"0D)+R\@4W1R:6YG+B!.
M;W)M86QL>2!T:&4 at 8VAA<G-E="!O9B!T:&4 at 8F%C:V5N9"!U<V5R<R!L86YG
M=6%G92!S96QE8W1I;VX@:7,@=7-E9"X at 268@>6]U('-E="!T:&ES('9A;'5E
M('1O(&$@8VAA<G-E="!F;W5N9"!I;B!T,VQI8B]C<V-O;G9T8FPO("AO<B B
M=71F+3 at B*2!T:&4 at 8F%C:V5N9" H86YD(&1A=&%B87-E*2!W:6QL($%,5T%9
M4R!U<V4@=&AI<R!C:&%R<V5T+B!!;'=A>7,@=7-E(&$@;&]W97)C87-E('9A
M;'5E+ at H@"0DG:6YS=&%L;%1O;VQ087-S=V]R9"<@/3X@)R<L"0D)+R\@4W1R
M:6YG+B!4:&ES(&ES('1H92!M9#4M:&%S:&5D('!A<W-W;W)D(&9O<B!T:&4@
M26YS=&%L;"!4;V]L+B!3970@=&AI<R!T;R G)R!A;F0 at 86-C97-S('=I;&P@
M8F4@=&]T86QL>2!D96YI960N(%!,14%312!C;VYS:61E<B!T;R!E>'1E<FYA
M;&QY('!A<W-W;W)D('!R;W1E8W0@=&AE('1Y<&\S+VEN<W1A;&PO(&9O;&1E
M<BP at 96<N('=I=&@@82 N:'1A8V-E<W, at 9FEL92X*( D))W1R86-K0F55<V5R
M)R ]/B P+ D)"0D)"2\O($)O;VQE86XN($EF('-E="P at 979E<GD@:6YV;VMA
M=&EO;B!O9B!A(&)A8VME;F0@<V-R:7!T(&ES(&QO9V=E9"!I;B!S>7-?=')A
M8VMB975S97(N(%1H:7,@:7,@=7-E9"!T;R!G970 at 82!V:65W(&]F('1H92!B
M86-K96YD('5S97)S(&)E:&%V:6]U<BX at 36]S=&QY(&9O<B!D96)U9V=I;F<L
M('-U<'!O<G0 at 86YD('5S97(@:6YT97)A8W1I;VX at 86YA;'ES:7,N(%)E<75I
M<F5S("=B975S97)?=')A8VMI;F<G(&5X=&5N<VEO;BX*+2 )"2=D969A=6QT
M57-E<E138V]N9FEG)R ]/B G;W!T:6]N<RYS:&]R=&-U=$9R86UE/3$G+ D)
M"2\O(%-T<FEN9RX at 16YT97(@;&EN97,@;V8 at 9&5F875L="!B86-K96YD('5S
M97(O9W)O=7 @5%-C;VYF:6<N"BL@"0DG9&5F875L=%5S97)44V-O;F9I9R<@
M/3X@)V]P=&EO;G,N<VAO<G1C=71&<F%M93TQ"BL)"0EO<'1I;VYS+F5N86)L
M95-H;W)T8W5T<STQ)RP)"0DO+R!3=')I;F<N($5N=&5R(&QI;F5S(&]F(&1E
M9F%U;'0 at 8F%C:V5N9"!U<V5R+V=R;W5P(%138V]N9FEG+ at H@"0DG9&5F875L
M=%!A9V544V-O;F9I9R<@/3X@)R<L"0D)+R\@16YT97(@;&EN97,@;V8 at 9&5F
M875L="!086=E(%138V]N9FEG+ at H@"0DG9&5F875L=%!E<FUI<W-I;VYS)R ]
M/B!A<G)A>2 H"0D)+R\@1&5F875L="!P97)M:7-S:6]N<R!S970 at 9F]R(&YE
M=R!P86=E<R!I;B!T,VQI8B]T8V5?;6%I;BYP:' N($ME>7, at 87)E("=S:&]W
M+&5D:70L9&5L971E+&YE=RQE9&ET8V]N=&5N="<N($5N=&5R(&%S(&-O;6UA
M+6QI<W0*("\O"0D))W5S97(G(#T^("<G+ D)"0D)"2\O(&1E9F%U;'0@:6X@
M=&-E7VUA:6X@:7,@)W-H;W<L961I="QD96QE=&4L;F5W+&5D:71C;VYT96YT
M)RX at 268@=&AI<R!I<R!S970@*'5N8V]M;65N="DL('1H:7,@=F%L=64@:7,@
-=7-E9"!I;G-T96%D+@``
`
end
More information about the TYPO3-team-core
mailing list