[TYPO3-core] RFC: #11731: [Bugfix] ENABLE_INSTALL_TOOL file check in yellow box doesn't check the file age

[Michael Stucki]

* Committed to TYPO3_4-2 (rev. @5827)
* Committed to Trunk (rev. @5828)

Issue remains open in the bugtracker until also TYPO3_4-1 is fixed.

Cheers, Michael

Michael Stucki schrieb:
> Hi Moreno,
> 
> some comments:
> 
> As discussed, @ on is_file checks is not good. However, since it is
> already in place in 4-1 and 4-2, this may now throw an error at a place
> where it didn't occure before. So therefore, I agree to remove the @ in
> Trunk but not in 4-1 and 4-2.
> 
> About the label change: Changing labels is bad because the translation
> manager does not notice the change, hence the other languages probably
> won't get updated.
> 
> In this case, I think this is acceptable because the label is accurate
> enough even if the word "permanently" is missing.
> 
> So +1 on reading and also testing.
> 
> - michael
> 
> Moreno Feltscher schrieb:
>> I'm fine with this change.
>>
>> Attached you find my final patch (v6) which also takes the localization
>> into account.
>> Nitpicking: we don't need the @ on file_exists, after some discussions
>> in the past ;)
>>
>>
>> Cheers
>> Moreno
>>
>> On Tue, 25 Aug 2009 15:42:41 +0200, Oliver Hader <oliver at typo3.org> wrote:
>>
>>> Hi again,
>>>
>>> Oliver Hader schrieb:
>>>> Hi Moreno,
>>>>
>>>> Moreno Feltscher schrieb:
>>>>> You're right, the comment wasn't correct. I now added a additional one
>>>>> so it should fit.
>>>>>
>>>>> Find new patch attached.
>>>> I'd still like to see the file_exists check - see attached new patch.
>>>>
>>>> Besides that:
>>>> +1 on reading and testing
>>> I just realized that we already had a v3 of the patch and in the
>>> bugtracker even a v4 - however here's the same file again as v5.
>>>
>>> olly
>>
> 
> 


-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/