[TYPO3-core] RFC #11764: speed up list module by improving internal handling of localisations

[Rupert Germann]

hi olly

thanks for testing.

I committed the attached patch to trunk rev 5824

changes:
* made $selFieldList a function parameter of translationInfo()
* removed $this->selfieldList from class transl8tools
* changed the query in function translationInfo() to use $selFieldList 
only if it is set - otherwise it falls back to the old behaviour

I tested it by loggin in as a non-admin user and localizing a record 
directly in tceforms.
That produced an error before the patch.
now it should work.


greets
rupert



Oliver Hader schrieb:
> Hi Rupert,
> 
> Rupert Germann schrieb:
>> FYI: committed to trunk rev 5814
>> final patch attached
>>
>> changes compared to first version:
>> - inserted missing spaces
>> - added description for the new parameter $row
>> - moved declaration of $this->translateTools to class.t3lib_recordlist.php
>> - added declaration for $this->translations
> 
> Some remarks and bugs:
> * if the User TSconfig "options.additionalPreviewLanguages" is set, IRRE
> and workspaces will produce SQL errors - reason in t3lib_transl8tools:
> | - 'uid,'.$TCA[$trTable]['ctrl']['languageField'],
> | + $this->selFieldList,
> 
> * the newly introduced class member t3lib_transl8tools->selFieldList is
> not defined at the top of the class and thus has no default value -
> besides that the fields to be selected should be delivered to the method
> instead of setting a class member variable at all since the method
> depends on a specific table and the class itself does not. Example:
> 
> | translationInfo($table, $uid, $sys_language_uid = 0, $selectFields =
> '', array $row = NULL) {
> | // and if $selectFields is empty, the old way is used
> 
> Thanks in advance for taking care of these issues!
> 
> olly