[TYPO3-core] RFC: #11771: Cleanup of tceforms.php

Steffen Ritter info at rs-websystems.de
Mon Aug 24 13:24:35 CEST 2009


Steffen Kamper schrieb:
> Hi Steffen,
> 
> Steffen Ritter schrieb:
> 
>> +1 by reading,
>> but one question, what does this function do, and why worked it 
>> without the parameter? If it is not needed - as it has not been there, 
>> why not completely remove it from the function body.
>>
> 
> in the function the $field is used as array key:
> $rowCopy[$field] = $imgPath;
> and needed for the call t3lib_BEfunc::thumbCode
> 
> It works with empty $field but raise a warning, which i eleminated.
> 
>> I would like you to split up when committing, so that the functional 
>> change of previeFieldValue could be reverted alone
>>
> 
> 
> no functional change, only warnings eleminated, so no need to split.
> 
> vg Steffen
ok, then, my +1 stays :P


More information about the TYPO3-team-core mailing list