[TYPO3-core] RFC #11657: sysaction uses hardcoded texts

Rupert Germann rupi at gmx.li
Thu Aug 20 15:02:23 CEST 2009


hi Christopher,

+1 by reading and testing

greets
rupert


Christopher Stelmaszyk schrieb:
> Hi!
> 
> This is a SVN patch request.
> 
> Type: feature
> 
> Branches: trunk
> 
> BT reference:
> http://bugs.typo3.org/view.php?id=11657
> 
> Problem:
> The sysext sysaction uses hardcoded labels.
> 
> Solution:
> The patch fixes that.
> 
> Kind regards
> 
> Christopher
> ------------------------------------------------------------------------
> Index: typo3/sysext/sys_action/class.tx_sysaction.php
> ===================================================================
> --- typo3/sysext/sys_action/class.tx_sysaction.php (revision 5751)
> +++ typo3/sysext/sys_action/class.tx_sysaction.php (working copy)
> @@ -196,14 +196,14 @@
>            '&SET[search]=query'.
>            '&storeControl[STORE]=-'.$actionRow["uid"].
>            '&storeControl[LOAD]=1'.
> -          '">Edit Query</a></strong>';
> +          '">' . $GLOBALS['LANG']->getLL('action_editQuery') . 
> '</a></strong>';
>          }
>          $theCode.= 
> $this->pObj->doc->section($LANG->getLL("action_t2_result"),$actionContent,0,1);
>         } else {
>          $theCode.= 
> $this->pObj->doc->section($LANG->getLL("action_error"),'<span 
> class="typo3-red">'.$LANG->getLL("action_notReady").'</span>',0,1);
>         }
>        } else {
> -       $theCode.= 
> $this->pObj->doc->section($LANG->getLL("action_error"),'<span 
> class="typo3-red">The extension "lowlevel" must be installed in order to 
> create a quiry</span>',0,1);
> +       $theCode.= 
> $this->pObj->doc->section($GLOBALS['LANG']->getLL("action_error"),'<span 
> class="typo3-red">' . $GLOBALS['LANG']->getLL('action_lowlevelMissing', 
> true) . '</span>',0,1);
>        }
>       break;
>       case 3: //list records
> Index: typo3/sysext/sys_action/locallang.xml
> ===================================================================
> --- typo3/sysext/sys_action/locallang.xml (revision 5751)
> +++ typo3/sysext/sys_action/locallang.xml (working copy)
> @@ -9,7 +9,9 @@
>     <label index="action_noType">Error: The action had no type 
> defined.</label>
>     <label index="action_notReady">Error: The action configuration is 
> not finished.</label>
>     <label index="action_download_file">Click here to download the 
> exported data in a file</label>
> +   <label index="action_editQuery">Edit Query</label>
>     <label index="action_error">Action error!</label>
> +   <label index="action_lowlevelMissing">The extension "lowlevel" must 
> be installed in order to create a query.</label>
>     <label index="action_BEu_hidden">Disable user</label>
>     <label index="action_BEu_username">Login name</label>
>     <label index="action_BEu_password">Password</label>
> 
> 


More information about the TYPO3-team-core mailing list