[TYPO3-core] RFC: #11731: [Bugfix] ENABLE_INSTALL_TOOL file check in yellow box doesn't check the file age

[Moreno Feltscher]

Hi Stucki "Wunsch-Bündner" ;)


So we now have different solutions for this:
1) leave it as it is (personally I don't think this is a good idea because  
it confuses people an the message is definitely wrong)
2) my solution with file age check and KEEP_FILE check (maybe a little bit  
too much..)
3) display a message only if KEEP_FILE is TRUE (my favorite one, the file  
will be deleted after one hour and admins have not to care about)
4) a remove function in typo3/init.php (I vote against this one because  
this will cost some performance due to filesystem access)

So what do you think about 3)?

I would write a patch for this one if nobody objects.


Cheers


On Mon, 17 Aug 2009 12:39:29 +0200, Michael Stucki <michael at typo3.org>  
wrote:

> Hi Francois & Moreno Party-Man ;-)
>
>>> No, you didn't get anything wrong. The problem is it could confuse
>>> people because the file will only be removed after the install tool
>>> was accessed. If you see the warning in the yellow box and you want to
>>> check whether the install tool is accessible it could be that your
>>> install tool deletes the file.
>>>
>>> The bug is more about "confusing people" than a technical change.
>
> I agree. Actually the real problem is that the file is already
> "scheduled" for removing but it will not be done before you access the
> Install Tool. So maybe the file removal should be integrated in
> typo3/init.php instead?
>
>> I understand better what you mean now. However, I'm still unfavorable to
>> the change you suggest: the fact is that the ENABLE_INSTALL_TOOL file
>> exists at that point and something should be done about deleting it. I
>> agree that it may cause some confusion, but the proposed is fixed is not
>> a good solution IMO.
>>
>> Moreover your patch is wrong, because it doesn't take into account the
>> "KEEP_FILE" feature.
>
> True. Now by copying the removal code from typo3/install/index.php to
> typo3/init.php this would be considerated, so nothing would need to be
> changed in class.t3lib_befunc.php.
>
> What do you think?
>
> - michael
>


-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/