[TYPO3-core] RFC: #11731: [Bugfix] ENABLE_INSTALL_TOOL file check in yellow box doesn't check the file age

[Steffen Ritter]

Francois Suter schrieb:
> Hi,
> 
>> No, you didn't get anything wrong. The problem is it could confuse 
>> people because the file will only be removed after the install tool 
>> was accessed. If you see the warning in the yellow box and you want to 
>> check whether the install tool is accessible it could be that your 
>> install tool deletes the file.
>>
>> The bug is more about "confusing people" than a technical change.
> 
> I understand better what you mean now. However, I'm still unfavorable to 
> the change you suggest: the fact is that the ENABLE_INSTALL_TOOL file 
> exists at that point and something should be done about deleting it. I 
> agree that it may cause some confusion, but the proposed is fixed is not 
> a good solution IMO.
> 
> Moreover your patch is wrong, because it doesn't take into account the 
> "KEEP_FILE" feature.
> 
> Cheers
> 
Why just not add some text "The file will be deleted automatically upon 
next Install-Tool-Hit" if keepfile=0 && file-time > 1h.

This would do the confusion job :)

regards