[TYPO3-core] RFC #11718: speed up function t3lib_iconWorks::skinImg()

Rupert Germann rupi at gmx.li
Fri Aug 14 19:03:49 CEST 2009


Ingo Renner schrieb:
> v4 contains changes that weren't part of the original patch, please 
> don't commit such things. Especially keep cleanups and changes 
> separated, please.

ok

> I'm especially refering to lines 30-33 in v4 where you added parantheses 
> that weren't there before.

CGL says (page 11):
Ternary conditional operator must be used only if it has two outcomes. 
Example:
$result = ($useComma ? ',' : '.');

so I added parantheses around the complete condition

> Stucki, who's just sitting next to me, did also notice this issue and is 
> going to fix it in a minute.

thanks Stucki, but now it looks like this:
$result = ($useComma) ? ',' : '.';

why is this better than the parantheses around the complete condition ?

greets
rupert






More information about the TYPO3-team-core mailing list