[TYPO3-core] RFC #11718: speed up function t3lib_iconWorks::skinImg()

Rupert Germann rupi at gmx.li
Fri Aug 14 14:36:39 CEST 2009


Oliver Klee schrieb:
> Hi,
> 
> Oliver Klee schrieb:
>> +1 by reading with the two following changes:
>>
>> - change empty to isset
>> - fix the indentation of $cachedSkinImages[$imageId] = $output; (it's
>> one tab too far)
> 
> I've attached a patch with these changes.

thanks, isset() reads much better.
to simplify it a bit more I'll remove the superfluous else{} statement 
after the cache condition during commit.

greets
rupert







More information about the TYPO3-team-core mailing list