[TYPO3-core] RFC: #11648: Feature: Add datepicker to date and datetime fields in TCEFORMS

Steffen Kamper info at sk-typo3.de
Wed Aug 5 14:39:26 CEST 2009


Hi Peter,

Peter Foerger schrieb:
> Hi Steffen,
> 
> two remarks.
> 
> First: although Javascript silently ignores it, wouldn't it be much
> cleaner to define convertDateFieldsToDatePicker() before calling it?
>

it doesn't matter really, but we can move the Ext.onReady-block to the 
end of the file

> Second: using dot notation would be much easier to read –
> eval(el.dom.attributes.onchange.value); as against
> eval(el.dom.attributes['onchange'].value);
> 

yes, looks cleaner. i will change that.

> Besides that +1 on reading and testing.
> 

thanks!

vg Steffen


More information about the TYPO3-team-core mailing list