[TYPO3-core] FYI24 Bug #11585: Faulty usage of t3lib_matchCondition in backend template

Oliver Hader oliver at typo3.org
Sun Aug 2 00:58:10 CEST 2009


FYI: Committed to SVN Trunk (rev. 5747)

olly


Oliver Hader schrieb:
> This is an SVN patch request that will be committed to SVN after 24
> hours if nobody objects.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=11585
> 
> Branch: Trunk
> 
> Problem:
> The backend base template (typo3/template.php) creates an instance of
> t3lib_matchCondition to determine browser information. However, it's not
> required to load the full t3lib_matchCondition class - besides that it's
> intended for TypoScript conditions in the frontend.
> This is a classical misuse...
> 
> Solution:
> Extract the methods browserInfo() and browserInfo_version() from
> t3lib_matchCondition and move them to a new class t3lib_div_browser.
> Since browserInfo() had a hook (which is still buggy),
> t3lib_matchCondition still calls $this->browserInfo().
> 
> Notes:
> This is a pre-cleanup for the feature "backend conditions". Find a unit
> test attached that tries to match some browser and version conditions.
> 
> olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3


More information about the TYPO3-team-core mailing list