[TYPO3-core] RFC: #10956: Validation issue: Trimming empty <strong> in typo3/alt_intro.php when module has no module label

Patrick Broens patrick at netcreators.com
Wed Apr 22 14:08:35 CEST 2009


Hi Oliver

Oliver Klee wrote:
> Hi,
> 
> +1 by reading with the following nitpicks:
> 
> - use != '' instead of !empty for testing for empty strings (to make
> your intent clearer to the reader)
See my remarks on issue 10954 about this

> - add the missing spaces around the . concatenation dots
This is non touched code! We have a rule that non touched code should
not be changed, otherwise you have to change the whole files.
> - only use the htmlspecialchar on the nonempty case (= after the test
> for emptiness)
Well ok, can go for that. But keep in mind $moduleDescription is not
tested fully on emptiness

Patrick
> 
> 
> Oliver


More information about the TYPO3-team-core mailing list