[TYPO3-core] RFC: Bug #8518: Wrong JavaScript inclusion in t3lib_TCEforms

Oliver Hader oliver at typo3.org
Sun Sep 28 21:54:50 CEST 2008


FYI: Committed to SVN:
* TYPO3_4-2 (rev. 4256)
* Trunk (rev. 4257)

olly


Christian Kuhn schrieb:
> Oliver Hader wrote:
>> This is a SVN patch request.
>>
>> Problem:
>> There are superfluos inclusions of javascript resources in
>> t3lib_TCEforms. Thus, it might happen that prototype.js is defined in
>> the HEAD part of the document and again somewhere in the BODY.
>>
>> Solution:
>> Use template::loadJavascriptLib() to include a javascipt library only
>> once.
>>
>> Comments:
>> Before this patch the JS libs where included somewhere in the BODY
>> tag, on using the mentioned function the libs will be included in the
>> HEAD tag now. However, this is no problem for the affected resources.
>> The patch removes a superfluos inclusion of scriptaculous that was
>> introduced in rev. 2628 - scriptaculous is not required for the
>> functionalities of that SVN revision.
>> Thanks to Benni Mack for writing the initial patch to utilize
>> template::loadJavascriptLib().
>>
>> References:
>> http://bugs.typo3.org/view.php?id=8518
>> http://forge.typo3.org/repositories/diff/typo3v4-core?rev=2628
>>
>> Branches: TYPO3_4-2, Trunk
> 
> +1 on reading and testing.
> 
> Attached patch re-adds the line break in $out.
> 
> Regards
> Christian
-- 
Oliver Hader
TYPO3 Release Manager 4.3


More information about the TYPO3-team-core mailing list