[TYPO3-core] RFC: #9372: Code in class.tx_tstemplateanalyzer.php don't match with the new CGL
Martin Kutschker
masi-no at spam-typo3.org
Thu Sep 18 11:35:16 CEST 2008
Steffen Kamper schrieb:
> Stefano Kowalke schrieb:
>> Hi,
>>
>> Here comes version 2 of the patch.
>>> Solution:
>>> * Add spaces
>>> * remove obsolete 'global $LANG' in modMenu() because not translation
>>> needed there
>>> * changing boolean '0' to 'false'
>>> * changing boolean '1' to 'true'
>> * replace double quotes with single quotes
>> * using $GLOBALS[] instead of global
>>
>> Stefano
>>
>>
>
> Hi Stefano,
>
> sry for the late - i don't like $GLOBALS['tmpl'], which is a approach we
> don't use anywhere for this purpose.
> You can change that to a class var, so $this->tmpl is available in any
> function then.
Did you analyse the code? There must be a reason this variables are
defined as globals.
I suggest we live them as they are for this nice reformatting patch. I
fear that the template main module interacts with its submodules via
this variables.
Masi
More information about the TYPO3-team-core
mailing list