[TYPO3-core] RFC #1957: Feature: When deleting a record in the BE, MsgBox should show the record label

Martin Kutschker masi-no at spam-typo3.org
Wed Sep 17 23:38:22 CEST 2008


Christian Kuhn schrieb:
> Hi,
> 
> Rob Vonk wrote:
>> In my latest patch (attached here and uploaded to the bugtracker),
>> I've put the slashJH around the message.
>>
>> And i changed the message and added a translation for the reference
>> count.
> 
> Beside some minor CGL issues (whitespaces around dots and after comma in
> function parameters) there is still a double htmlspecialchars() of the
> title. Just create a record with a " in the title and you will see an
> " in the popup.
> I suggest to remove the first call (in $titleOrig = ).
> 
> If this is fixed +1 on reading and testing, nice patch!

And the slashJS has not been added. I've changed the patch (see
attachment and commited the stuff).

Now the code has correct order of title processing: get it, truncate to
characters, apply JS slashing. The hsc is done for the complete string
it is added to, no extra hsc for the title.

Masi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_1957.patch
Type: text/x-diff
Size: 1806 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080917/c75ac892/attachment.patch 


More information about the TYPO3-team-core mailing list