[TYPO3-core] RFC: #9360: TypoScript Object Browser interprets HTML Tags in comments

[Stefano Kowalke]

Hi,

This is an SVN patch request.

Type: Bugfix

Bugtracker reference: http://bugs.typo3.org/view.php?id=9360

Branches: 4.2, trunk

Problem:
In TypoScript you could add comments to your code. Comments begin with #
or // and could contain HTML tags like <table>,... . The TypoScript Object
Browser display this comments (if selected) and interpret the HTML tags.

As one result of interpreting HTML the design of the TypoScript Object
Browser crashs like in the screenshot.

In the screenshot the error occur at line
'[externalBlocks] = table, blockquote, ol,ul // makelinks > # Processing and
blocks separately'
because the comment contains a <table> and a <blockquote> Tag -> '//
makelinks > # Processing <table> and <blockquote> blocks separately'
which both was interprets by TSOB.

After this error the brackets and the value of a TS property was displayed
in red. 

Additional Informations:
Follow this steps to reproduce:

* Go to template module and choose a template
* Open [lib].[parseFunc_RTE].[externalBlocks]

* Be sure that [lib].[parseFunc_RTE].[externalBlocks] comes from
typo3/sysext/css_styled_content/static/setup.txt

and containing at line 94: # Processing <table> and <blockquote> blocks
separately

Solution:
Masking HTML Tags with makeHtmlspecialchars()

Stefano
-- 
GPG-ID: 0x2B08936D
Key-Fingerprint: 7F31 BCF0 70C0 B3B1 1235 07E9 1777 D7A0 2B08 936D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: class.t3lib_tsparser_ext.php.diff
Type: text/x-diff
Size: 825 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080916/a50c9dad/attachment-0001.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TSOB_after.jpg
Type: image/jpeg
Size: 42596 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080916/a50c9dad/attachment-0002.jpg 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TSOB_before.jpg
Type: image/jpeg
Size: 36845 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080916/a50c9dad/attachment-0003.jpg