[TYPO3-core] RFC: #9318: Enhance and fix tslib_eidtools

Steffen Kamper info at sk-typo3.de
Fri Sep 12 21:31:22 CEST 2008


Dmitry Dulepov [typo3] schrieb:
> Hi!
> 
> Martin Kutschker wrote:
>> connectDB() never sets it's static variable $dbConnected to true. I
>> guess you wanted to write (assuming it reportes success with a boolean):
>>
>> $dbConnected = $GLOBALS['TYPO3_DB']->connectDB();
> 
> You are right, my mistake. I fixed it, except that I always set it to 
> true, regardless of connection result. It does not make sense to connect 
> again if connection already failed.
> 
> Here is the updated patch together with a better comment in a function 
> that Benni mentioned.
> 

+1 from reading

very good structure and code quality + readability, well done!

vg Steffen


More information about the TYPO3-team-core mailing list