[TYPO3-core] RFC: #9318: Enhance and fix tslib_eidtools

Dmitry Dulepov [typo3] dmitry at typo3.org
Fri Sep 12 08:45:04 CEST 2008


Hi!

Martin Kutschker wrote:
> connectDB() never sets it's static variable $dbConnected to true. I
> guess you wanted to write (assuming it reportes success with a boolean):
> 
> $dbConnected = $GLOBALS['TYPO3_DB']->connectDB();

You are right, my mistake. I fixed it, except that I always set it to true, regardless of connection result. It does not make sense to connect again if connection already failed.

Here is the updated patch together with a better comment in a function that Benni mentioned.

-- 
Dmitry Dulepov
TYPO3 Core team
My TYPO3 book: http://www.packtpub.com/typo3-extension-development/book
In the blog: http://typo3bloke.net/pages/book-reviews/presentation-zen-by-garr-reynolds/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 9318_v2.diff
Type: text/x-diff
Size: 5426 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080912/a3800e1d/attachment-0001.diff 


More information about the TYPO3-team-core mailing list