[TYPO3-core] RFC: #8644: Usersettings with fullHelptextMode looks weird

Benjamin Mack benni at typo3.org
Thu Sep 11 19:55:13 CEST 2008


Commited your patch to trunk and 4.2. However, I don't like the solution 
yet as a final thing, maybe we could revamp this module (maybe in a MVC 
style) for 4.3?

Steffen Kamper wrote:
> Benjamin Mack schrieb:
>> Hey Steffen,
>>
>> what's the status here?
>>
>> Benjamin Mack wrote:
>>> Hey Steffen,
>>>
>>> very nice patch.
>>>
>>> Some remarks...
>>>
>>> Hunk #2:
>>>
>>> +$this->doc->tableLayout['defRowEven'] = array (
>>> +    'defCol' => array (
>>> +        '<td valign="top" colspan="3">','</td>'
>>> +    ),
>>> +);
>>>
>>> we can unify line 2-4 in one line (just like in hunk #1)
>>>
>>> Basically in all places where you have
>>>   t3lib_BEfunc::cshItem('_MOD_user_setup', 'simuser', $BACK_PATH,'|');
>>> you can remove the last parameter, as this wrap is empty by default 
>>> anyway.
>>>
>>> Could you clean them up? I will now give the thing a test-run.
>>>
>>
> 
> Hi Benni,
> 
> here is a modified patch taking your remarks into account.
> 
> vg Steffen
> 

-- 
All the best,
benni.
-SDG-


More information about the TYPO3-team-core mailing list