[TYPO3-core] RFC: #9283: declare marker handling functions of t3lib_parsehtml static

Martin Kutschker masi-no at spam-typo3.org
Wed Sep 3 21:57:45 CEST 2008


Ingo Renner schrieb:
> Hi
> 
> This is an SVN patch request.
> 
> Type: Cleanup
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=9283
> 
> Branches: trunk
> 
> Problem:
> 1) The marker handling functions in t3lib_parsehtml are often called
> staticaly although there're not declared static (even is the case within
> t3lib_parsehtml itself).
> According to http://ilia.ws/files/ez_performance.pdf [^] this results in
> a drop of performance, other than that it produces notices or warnings
> and it is not good in general of course.
> 
> 2) There's an inconsistency: although a method substituteMarkerArray()
> exists, there's no substituteSubpartArray()
> 
> 
> Solution:
> 1) Declare those methods static
> 2) introduce the missing method substituteSubpartArray()

+1 but could please change the strtr replacement for strtoupper into a
call to t3lib_div::strtoupper.

Masi


More information about the TYPO3-team-core mailing list