[TYPO3-core] RFC: #9661: extend condition for globalVar

Xavier Perseguers typo3 at perseguers.ch
Fri Oct 31 13:57:10 CET 2008


Hi Steffen,

>> although I'd really like to see this feature in there, I would love to 
>> make this more clear to have "one-character-operators" and 
>> "two-char-operators" in the code, only allowing '=', '<', '>', '<=', 
>> '!=', '>='. This makes the whole thing easier to understand for people 
>> who read the code, and they are not confused with possible other 
>> options which default to some compeltely other code.
>>
> 
> so adding comments to code would help or enhance the check?

I would enhance the code to clearly see which operators (single or 
double-char) are allowed and how they are treated. And then clearly 
fallback for all others to == as it is now.

The problem with current code is that double-character operators are 
handled in the one-character operator parser. This works but is not very 
clear. Better would be to actually parse the single/double-character 
operator and *then* handle it.

-- 
Xavier Perseguers
http://xavier.perseguers.ch/en/tutorials/typo3.html


More information about the TYPO3-team-core mailing list