[TYPO3-core] RFC: #9581: clean up t3lib_exec

Oliver Hader oliver at typo3.org
Tue Oct 21 13:09:18 CEST 2008


Hi Steffen,

Steffen Kamper schrieb:
> Steffen Kamper schrieb:
>> Hi Dmitry,
>>
>> thx!
>> There was one $TYPO3_CONF_VARS left in xclass at the bottom.
> 
> sry, here is the correct patch adding this 2 $GLOBALS['TYPO3_CONF_VARS']

How can I easily test, that all of the changes work?

Line 10: double spaces
Line 42: it does not update global vars anymore
Line 46: change to "mixed" please
Line 285: 'allPaths' was removed - was this required at some other place?
Line 362: IMO there should first be an if-block to set the $imPath and
not everything in one line
Line 387: should be "(TYPO3_OS == 'WIN' ? ';' : ':');
Line 437: Please revert this change

In general, I'd like to see functional changes (new class members, new
functions, whatever) separated from cleanups (whitespaces/blanks,
obvious public/static declarations). This makes it easier to review
changes... thanks!

olly
-- 
Oliver Hader
TYPO3 4.3 Release Manager


More information about the TYPO3-team-core mailing list