[TYPO3-core] RFC: #9591: Integrate sys_actions into toolbar

Ernesto Baschny [cron IT] ernst at cron-it.de
Tue Oct 21 10:17:35 CEST 2008


Hi Ingo,

Ingo Renner wrote: on 20.10.2008 17:29:

> please find the revised patch attached

Some sidenode first: These snippets in your patch:

+include_once($TYPO3_CONF_VARS[TYPO3_MODE]['XCLASS']['ext/sys_action/toolbarmenu/class.tx_sysaction_toolbarmenu.php']);
+}
+
+?>\ No newline at end of file

together with the MS-DOS newlines at the end of the lines made the patch
create those strings at the end of the files when applying under Linux
(which then showed up in the browser):

?>\ No newline at end of file

Could you post the patches with Unix-Linefeeds, so that no "translation"
is needed before applying?


Now about the patch itself: I was about to discuss it in HCI team list,
I wonder why you think this is not an HCI issue. It adds new icons and
functionality to the backend and in my eyes it needs to be discussed and
acknoledged there, at least we should try it.

Output I expect there are stuff like: does it make sense at all? If yes,
maybe some nice icon could be created and some other HCI issues with the
implementation itself could be solved (maybe the position of the
top-level icon, maybe some other stuff that we haven't even thought about).

If we don't discuss these "small issues" with HCI, I fear we will never
discuss anything with them and just do as we wish. Let's give it a try?

Cheers,
Ernesto


More information about the TYPO3-team-core mailing list