[TYPO3-core] RFC #9474: Integrate OpenID authentication support to TYPO3

[Michael Stucki]

Hi Dmitry,

Dmitry Dulepov wrote:
> Michael Stucki wrote:
>> I didn't look at the patch at all. It is pretty huge, therefore I would
>> like to ask you for a patch that contains only the modifications you did
>> to the OpenID library plus the other stuff that you have added. Does
>> that make sense?
> 
> My work on this patch is finished. I spent hours on it. If you want me
> to work more on it, I am ready to do it at my standard hourly rate.
> Otherwise - sorry, I need to get money to feed my kids. My daily work is
> waiting.

I'm sorry if you took my comments the wrong way - sorry but it was not
meant to be negative in any way. My request had a very practical reason
which is to review only your modifications instead of reviewing a
complete 3rd-party product which is some 17'000 lines long!

> You, guys, can go on, rename variables, split patches, add big yellow
> boxes. I made the patch, which I consider to have high quality and ready
> for integration. This patch was the only piece of code that was complete
> after Hackontest and did not have issues. If you do not think it is
> ready – fine with me. Everyone has right for his own opinion. Now the
> patch is yours.

Please calm down. I just did what I asked you for, and - surprise - it
turned out that you made a very clean separation which is likely to be
overlooked in this huge patch. The new patch is only 983 lines long and
therefore quite easy to review. Congratulations for the really good work!

Attached are two patches, one being the integration of the library in
TYPO3, and the other one containing the modifications which you did to
the PHP OpenID library. It wasn't too hard to do after all, but for your
personal interest I suggest that you do it the same way next time,
because reviewing (in regards of security not functionality!) is really
much simpler that way.

You have my +1 now.

- michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: openid_integration.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20081020/777e5f41/attachment-0001.txt 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: php-openid-typo3.patch
Type: text/x-patch
Size: 1786 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20081020/777e5f41/attachment-0001.bin