[TYPO3-core] RFC #9523: class.t3lib_htmlmail.php produces null headers in HTML messages

Martin Kutschker masi-no at spam-typo3.org
Fri Oct 10 10:29:11 CEST 2008


Xavier Perseguers schrieb:
> Hi,
> 
>>> as although declared as public, the getHTMLContentType() method is used
>>> only from within the class itself.
>>
>> "public" and friends were only possible in 4.2 after the switch to PHP5.
>> To avoid breaking older stuff protected is only used for new methods.
> 
> Yes, just to notice that it would have been better to write a @private
> in the comments, just as it was good-coding before PHP5.

But declaring it as "public" and commenting it as @private would raise
questions again :)

Then you would need an extra comment that explains why there is a
difference.

Masi


More information about the TYPO3-team-core mailing list