[TYPO3-core] RFC #9523: class.t3lib_htmlmail.php produces null headers in HTML messages

Xavier Perseguers typo3 at perseguers.ch
Thu Oct 9 11:52:40 CEST 2008


Hi François,

>> Solution:
>>
>> Revert to valid behaviour of 4.2.1 with attached patch.
> 
> The fix seems pretty obvious, but the extra semi-colon was introduced in 
> revision 3937, that fixed bug #8255: Problems with PHP mail function on 
> Windows. The final patch was reviewed and updated by Dmitry. It would be 
> interesting to have his opinion about this semi-colon problem. Will 
> removing it "unfix" bug #8255?

I just checked out how bug #8255 was fixed and I recognize the diff I 
read this morning ;-)

Well I see that my patch might need to fix the same problem in method 
constructMixed() as this duplicated semicolon is there too.

Now, bug #8255 was about a problem with "to" and "from" on Windows, not 
a problem about boundaries. Patch has merged correction of #8199 too. 
And this patch (8199.patch) introduced the bug. It adds the semicolon to 
all "Content-Type" headers without noticing that getHTMLContentType 
already outputs it as part of its return statement. 8199.patch merged 
into patch from #8255 was not well-tested and should be partly reverted.

-- 
Xavier Perseguers
http://xavier.perseguers.ch/en


More information about the TYPO3-team-core mailing list