[TYPO3-core] RFC: #8903: redirect url is not passed with get/post method

Ingmar Schlecht ingmar at typo3.org
Wed Nov 12 20:16:10 CET 2008


Hi Steffen,

Steffen Kamper schrieb:
> Hi,
> 
> this is a SVN patch request.
> 
> Type: Bugfix
> 
> BT Reference: http://bugs.typo3.org/view.php?id=8903
> 
> Branches: Trunk, 4.2
> 
> Problem:
> When the url contains redirect_url and redirect method is set to getpost
> it will not proceeded as the parameter is not passed correctly.
> 
> Solution:
> treat the case in processRedirect when $this->logintype isn't set and
> pass the redirect_url. Also pass it after login error.

I just reviewed the code, +1.

Just one nitpicking: The URL should be named $gpRedirectUrl instead of
$gpRedirecturl, so please change that before committing.

I suggest that you commit this right away, because:
  - you said (on skype) that a bunch of people has tested this
  - felogin is basically your baby
  - it's just a small patch, and I can confirm that old functionality
    wouldn't break

So go for it!

cheers
Ingmar


-- 
Ingmar Schlecht
TYPO3 Association Active Member


More information about the TYPO3-team-core mailing list