[TYPO3-core] RFC #8497 User Admin > Compare User Settings Inconsistencies

Martin Kutschker martin.kutschker-n0spam at no5pam-blackbox.net
Sun May 25 12:20:35 CEST 2008


Michiel Roos schrieb:
> Hi people,
> 
> This is a HCI related SVN patch request.
> 
> Branches: trunk + TYPO3 4.2
> 
> Type: Visual cleanup
> 
> BT reference:  http://bugs.typo3.org/view.php?id=8497
> HCI reference: http://forge.typo3.org/issues/show/630
> 
> Problem:
> - checkbox list is too long
> - the save button in the docheader should not be a sav button but an 
> update button
> - the save button is too far away from the checkboxes, breaks the flow 
> in this case
> 
> Solution:
> - Grouped the checkbox list into three columns;
> - Removed the 'save' icon from the docHeader;
> - Put back the update button, close to the checkboxed, where the admin 
> expects it;
> - Added a vertical-align: top for td and th to the default style.

The screenshot looks fine, so +1 from reading with one exception. You 
have added a general CSS rule for this patch. Is it ok to use top-align 
for *all* TDs and THs? Maybe but this is definitely a major change that 
should be checked. So I'm a bit unsure if this may go to 4.2.

Masi


More information about the TYPO3-team-core mailing list