[TYPO3-core] RFC: #8460: Shortcutmenu needs a proper access check

Steffen Kamper steffen at sk-typo3.de
Mon May 19 18:29:34 CEST 2008


"Stefano Kowalke" <blueduck at gmx.net> schrieb im Newsbeitrag 
news:mailman.1.1211214438.6373.typo3-team-core at lists.netfielders.de...
> Stefano Kowalke wrote:
>
>> Steffen Kamper wrote:
>>
>>>
>>> "Stefano Kowalke" <blueduck at gmx.net> schrieb im Newsbeitrag
>>> news:mailman.1.1211206628.10170.typo3-team-core at lists.netfielders.de...
>>>> Hi,
>>>>
>>>> This is an SVN patch request.
>>>>
>>>> Bugtracker references:
>>>> http://bugs.typo3.org/view.php?id=8460
>>>>
>>>> Branches:
>>>> 4.2, Trunk
>>>>
>>>> Problem:
>>>> The function checkAccess() in typo3/classes/class.shortcutmenu.php give
>>>> always "true" back.
>>>>
>>>> Solution:
>>>> *See patch
>>>>
>>>> Saludos
>>>> Stefano
>>>> --
>>>
>>> Hi,
>>>
>>> same opinion as with search. Search and Shortcuts are helpful tools for
>>> each editor that should be there all the time.
>>> I also found no restriction in old BE.
>>>
>>> vg Steffen
>>
>> Yes your are right. I just saw the FIXME Comment.
>> In this case the whole function could be removed.
>>
>> LG
>> Stefano
>>
> After a look around in code, i think the best way is remove only the 
> comment
> and/or add a new comment to explain why the function give always "true"
> back.
>

I agree. So feel free to do a patch for search and shortcut with a proper 
comment

vg Steffen 




More information about the TYPO3-team-core mailing list