[TYPO3-core] RFC #8049 Save button don't work when deactivating t3editor

Tobias Liebig mail_news at etobi.de
Thu May 15 15:25:12 CEST 2008


Dmitry Dulepov [typo3] wrote:
> Tobias Liebig wrote:
>> i cleaned up the patch..
>> here we go
> 
> But this cleanup removed comment marks. Are you sure this is a right thing?

to un-comment these lines is correct in this case (the initial patch
does the same). these lines should NOT be commented. this is almost all
the patch is doing.

Differences between both patches (initial and last):
	- Cleanup, like you suggest: remove the out commented line
		// && !Prototype.Browser.IE

	- and add this line:
		this.saveFunctionEvent = this.saveFunction.bind(this);
	  to make sure that saveFunctionEvent is set, when reactivating
	  the Editor

So the last patch (patch_t3editor_20080429_8049b.diff) is the right one
to review/test.

thanks
  tobias


More information about the TYPO3-team-core mailing list