[TYPO3-core] RFC #8271: Bugfix: OpenDocs Icons: Hardcoded labels in title and alt-attributes

Stefano Kowalke blueduck at gmx.net
Wed May 7 01:27:09 CEST 2008


This is an improvement

Improvement 1:
Instead using 
$GLOBALS['LANG']->sL('LLL:EXT:opendocs/locallang_opendocs.xml:toolbaritem', 
true);
i make use of getLL() because the xml-file was loaded by default and other
labels from 'locallang_opendocs' was taken too.

Improvement 2:
i found another hardcoded label (title [and no alt] attribute from
Close-Button) and make this translatable.
I took the label with sL() from typo3/sysext/lang/locallang_core.xml,
because its more file-safe translate a label only one time. 
Besides it helps to keep the translations consistent.  

Stefano

Stefano Kowalke wrote:

> Hey,
> 
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=8271
> 
> Branches:
> 4.2, Trunk
> 
> Problem:
> Title and alt attributes from OpenDocs icon in
> backends upper right corner are hardcoded and not be able to translate.
> 
> Solution:
> Replace the hardcoded label in
> typo3_src-4.2.0/typo3/sysext/opendocs/class.tx_opendocs.php
> with
> $GLOBALS['LANG']->sL('LLL:EXT:opendocs/locallang_opendocs.php:open_docs');
> 
> Saludos
> Stefano
> 

-- 
Seit dem 1.1.2008 werden Daten zu jeder E-Mail verdachtsunabhängig gespeichert! 
Weitere Informationen: www.vorratsdatenspeicherung.de
GPG-ID: 0x2B08936D
Key-Fingerprint: 7F31 BCF0 70C0 B3B1 1235 07E9 1777 D7A0 2B08 936D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_8271_class.tx_opendocs.php.diff
Type: text/x-diff
Size: 1834 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080507/19a1a5ca/attachment.diff 


More information about the TYPO3-team-core mailing list