[TYPO3-core] RFC: bug #7784: Check for mail configuration is wrong on Windows

[Martin Kutschker]

Dmitry Dulepov [typo3] schrieb:
>>
>> The localhost check will fail on machine with an IPv6 interface. AT 
>> least I think so, I have not seen such a machine in real life.

I'm tlaking about this:

if ($smtp_addr == '127.0.0.1' && $_SERVER['SERVER_ADDR'] == '127.0.0.1')

In my second reading I also wonder now why you check the content of 
$_SERVER['SERVER_ADDR']? The machine may have a) an IP address and b) 
you may access it via HTTP from anaother machine and still could c) SMPT 
be set to localhost.

So I think this is sufficient:

if ($smtp_addr == '127.0.0.1' || $smtp_addr == '::1') ...

Other than that +1 from reading.

And there seems to be a typo in this message:

"Mail configuration is not setPHP mail() function requires SMTP and 
smtp_port to have correct values on Windows."

I suggest (set->valid plus punctuation):

"Mail configuration is not valid. PHP mail() function requires SMTP and 
smtp_port to have correct values on Windows."

Masi