[TYPO3-core] RFC #7906: Code cleanup: PHP5ize t3lib_BEfunc to bring in line with it's documentation.

Kasper Ligaard kasperligaard at gmail.com
Wed Mar 19 20:43:53 CET 2008


Error in previous patch format fixed in attached patch.

Regards, Kasper

On ons, 2008-03-19 at 19:45 +0100, Kasper Ligaard wrote:
> Updated t3lib_BEfunc-patch:
> 
> - Class is marked final.
> - Tabs has been subst. for a space between function declaration an '{'.
> - Inserts a space after commas in function signature, where appropriate
> according to CGL.
> - Inserts a space on each side of = signs, where appropriate according
> to CGL.
> 
> Regards, Kasper
> 
> On ons, 2008-03-19 at 14:12 +0100, Kasper Ligaard wrote:
> > This is an SVN patch request.
> >         
> > Type: Code cleanup
> > 
> > Bugtracker references: http://bugs.typo3.org/view.php?id=7906
> >         
> > Branches: TYPO3_4-2
> > 
> > Problem:
> > In the documentation for t3lib_extBEfunc it states:
> >         
> > "Standard functions available for the TYPO3 backend. Don't instantiate -
> > call functions with "t3lib_BEfunc::" prefixed the function name."
> >         
> > Now that we have PHP5 as a minimum we should make the function in
> > t3lib_extBEfunc 'public static'. Without running 'public static'
> > E_STRICT warnings are given to people using the class as documented, and
> > not giving errors to people using it wrongly (e.g. instantiating it)
> > 
> > Solution:
> > - The attached patch adds 'public static' to all the function of
> > t3lib_extMgm.
> > - It marks the class final
> > - It replaces tabs between function declarations and '{' with a space.
> >         
> > Notes:
> > - I know Typo3 does not use E_STRICT, but I still think the proposed
> > change would benefit all.
> > - This patch request is similar to
> > http://bugs.typo3.org/view.php?id=7350
> > - This patch is very similar to http://bugs.typo3.org/view.php?id=7903
> > - I have found no place in Typo3 where t3lib_extBEfunc are instantiated,
> > so this change should be safe.
> >         
> > Regards, Kasper
-------------- next part --------------
A non-text attachment was scrubbed...
Name: public-static-t3lib_befunc-rev2-1.patch
Type: text/x-patch
Size: 144608 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080319/2907c98c/attachment-0001.bin 


More information about the TYPO3-team-core mailing list